Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update painting_in_the_world.md #623

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

ljhwang
Copy link
Contributor

@ljhwang ljhwang commented Feb 16, 2024

Extensive editing for clarity. Please review carefully. No guarantee I did not introduce additional typos!

Feel free to edit.

Extensive editing for clarity.  Please review carefully.

Feel free to edit.
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo! Otherwise looks good to me.

doc/sphinx/user_manual/concepts/painting_in_the_world.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfbb30b) 93.11% compared to head (7ddbbe3) 92.54%.
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   93.11%   92.54%   -0.58%     
==========================================
  Files          92       92              
  Lines        6334     6369      +35     
==========================================
- Hits         5898     5894       -4     
- Misses        436      475      +39     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbb30b...7ddbbe3. Read the comment docs.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 16, 2024
@MFraters MFraters merged commit 5c2bd66 into GeodynamicWorldBuilder:main Feb 16, 2024
32 of 34 checks passed
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.011 ± 0.004 (s=449) 1.013 ± 0.005 (s=443) +0.1% .. +0.3%
Slab interpolation curved simple none 1.018 ± 0.004 (s=442) 1.018 ± 0.005 (s=445) -0.0% .. +0.2%
Spherical slab interpolation simple none 1.168 ± 0.007 (s=380) 1.168 ± 0.007 (s=393) -0.1% .. +0.1%
Slab interpolation simple curved CMS 1.060 ± 0.004 (s=449) 1.057 ± 0.004 (s=404) -0.4% .. -0.2%
Spherical slab interpolation simple CMS 1.546 ± 0.009 (s=281) 1.543 ± 0.009 (s=304) -0.4% .. -0.0%
Spherical fault interpolation simple none 1.165 ± 0.011 (s=396) 1.165 ± 0.011 (s=379) -0.2% .. +0.2%
Cartesian min max surface 2.310 ± 0.017 (s=185) 2.312 ± 0.026 (s=207) -0.2% .. +0.4%
Spherical min max surface 7.193 ± 0.023 (s=60) 7.209 ± 0.028 (s=67) +0.0% .. +0.4%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants