-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spatially variable spreading rates at ridges #617
Add spatially variable spreading rates at ridges #617
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 93.11% 92.50% -0.62%
==========================================
Files 92 92
Lines 6334 6457 +123
==========================================
+ Hits 5898 5973 +75
- Misses 436 484 +48
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR contains many different kinds of unrelated changes and also reintroduces typos in a few places. It might make sense to review this PR carefully and maybe split it into several PRs.
include/world_builder/parameters.h
Outdated
@@ -107,7 +107,7 @@ namespace WorldBuilder | |||
T get(const std::string &name); | |||
|
|||
/** | |||
* A specialized version of get which can return vectors/arrays. | |||
* A specialized verions of get which can return vecors/arrays. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos
- **maxItems**:2 | ||
- **description**: | ||
- **maxItems**:2.0 | ||
- **documentation**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this means that you generated the output with an older version. Can you rebase to the current main and rerun the tests to generate a new version of this file?
d6854a6
to
6c00e94
Compare
Address Issue #533. Adds spatial variation for spreading centers in the half space temperature feature for oceanic plates. This requires a new parsing function that I called value_at_array that allows worldbuilder to extract an array of size N for a single value. This was done to prepare for new functionality that will be added to address #534. This will allow the user to specify the spreading rate at past times as well as specify spatial variations.