Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test case for gwb_grid in sphere. #616

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

alarshi
Copy link
Contributor

@alarshi alarshi commented Feb 16, 2024

This PR adds a test case for using sphere in gwb_grid (#526)

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffbe304) 93.12% compared to head (bba5f2b) 93.11%.
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   93.12%   93.11%   -0.01%     
==========================================
  Files          92       92              
  Lines        6324     6332       +8     
==========================================
+ Hits         5889     5896       +7     
- Misses        435      436       +1     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4148ed8...bba5f2b. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.017 ± 0.007 (s=448) 1.017 ± 0.004 (s=439) -0.2% .. +0.0%
Slab interpolation curved simple none 1.018 ± 0.005 (s=496) 1.015 ± 0.006 (s=392) -0.4% .. -0.1%
Spherical slab interpolation simple none 1.167 ± 0.013 (s=381) 1.166 ± 0.005 (s=393) -0.2% .. +0.2%
Slab interpolation simple curved CMS 1.057 ± 0.005 (s=443) 1.056 ± 0.004 (s=411) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.545 ± 0.008 (s=274) 1.545 ± 0.010 (s=311) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.171 ± 0.006 (s=378) 1.171 ± 0.005 (s=393) -0.1% .. +0.1%
Cartesian min max surface 2.316 ± 0.024 (s=178) 2.313 ± 0.017 (s=213) -0.4% .. +0.2%
Spherical min max surface 7.272 ± 0.054 (s=61) 7.294 ± 0.053 (s=65) -0.1% .. +0.7%

@tjhei tjhei merged commit 589b9de into GeodynamicWorldBuilder:main Feb 16, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants