Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update features.md #614

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update features.md #614

merged 1 commit into from
Feb 15, 2024

Conversation

ljhwang
Copy link
Contributor

@ljhwang ljhwang commented Feb 15, 2024

More editing for clarity.

More editing for clarity.
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (180ea68) 93.12% compared to head (ffbe304) 93.12%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files          92       92           
  Lines        6324     6324           
=======================================
  Hits         5889     5889           
  Misses        435      435           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180ea68...ffbe304. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 0.972 ± 0.004 (s=468) 0.971 ± 0.004 (s=461) -0.2% .. +0.0%
Slab interpolation curved simple none 0.970 ± 0.004 (s=470) 0.970 ± 0.003 (s=460) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.127 ± 0.006 (s=390) 1.128 ± 0.006 (s=411) -0.1% .. +0.2%
Slab interpolation simple curved CMS 0.992 ± 0.013 (s=485) 0.992 ± 0.014 (s=425) -0.3% .. +0.3%
Spherical slab interpolation simple CMS 1.508 ± 0.009 (s=289) 1.508 ± 0.015 (s=310) -0.2% .. +0.2%
Spherical fault interpolation simple none 1.131 ± 0.006 (s=409) 1.132 ± 0.006 (s=389) -0.1% .. +0.2%
Cartesian min max surface 2.176 ± 0.017 (s=207) 2.176 ± 0.019 (s=209) -0.3% .. +0.3%
Spherical min max surface 6.920 ± 0.020 (s=77) 6.925 ± 0.030 (s=56) -0.2% .. +0.3%

@tjhei
Copy link
Contributor

tjhei commented Feb 15, 2024

Thank you!

@tjhei tjhei merged commit 260c854 into GeodynamicWorldBuilder:main Feb 15, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants