Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwb-grid: support tags #612

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 15, 2024

  • add tag output field in gwb-grid
  • remove a forgotten debug output in continental-plate
  • update test output

- add tag output field in gwb-grid
- remove a forgotten debug output in continental-plate
- update test output
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (180ea68) 93.12% compared to head (0f52501) 93.15%.
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   93.12%   93.15%   +0.03%     
==========================================
  Files          92       92              
  Lines        6324     6328       +4     
==========================================
+ Hits         5889     5895       +6     
+ Misses        435      433       -2     
Files Coverage Δ
source/world_builder/features/continental_plate.cc 100.00% <ø> (+1.12%) ⬆️
source/gwb-grid/main.cc 46.98% <90.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180ea68...0f52501. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 0.969 ± 0.004 (s=449) 1.013 ± 0.005 (s=461) +4.4% .. +4.6%
Slab interpolation curved simple none 0.973 ± 0.004 (s=454) 1.016 ± 0.005 (s=454) +4.3% .. +4.5%
Spherical slab interpolation simple none 1.130 ± 0.007 (s=388) 1.169 ± 0.007 (s=397) +3.3% .. +3.6%
Slab interpolation simple curved CMS 1.010 ± 0.005 (s=449) 1.053 ± 0.007 (s=426) +4.1% .. +4.4%
Spherical slab interpolation simple CMS 1.510 ± 0.011 (s=303) 1.549 ± 0.016 (s=288) +2.3% .. +2.8%
Spherical fault interpolation simple none 1.133 ± 0.006 (s=381) 1.173 ± 0.010 (s=402) +3.3% .. +3.7%
Cartesian min max surface 2.172 ± 0.024 (s=203) 2.317 ± 0.044 (s=201) +6.1% .. +7.2%
Spherical min max surface 6.932 ± 0.028 (s=62) 7.234 ± 0.034 (s=67) +4.1% .. +4.6%

@MFraters MFraters merged commit 01ca9df into GeodynamicWorldBuilder:main Feb 16, 2024
33 of 34 checks passed
@tjhei tjhei deleted the gwb-grid-support-tag branch February 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants