Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update included.md #590

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Update included.md #590

merged 3 commits into from
Feb 15, 2024

Conversation

ljhwang
Copy link
Contributor

@ljhwang ljhwang commented Feb 14, 2024

More than usual editing to improve clarity and lessen wordiness.

Please feel free to edit.

More than usual editing to improve clarity and lessen wordiness. 

Please feel free to edit.
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30ae879) 93.55% compared to head (83c092c) 93.40%.
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   93.55%   93.40%   -0.16%     
==========================================
  Files          92       92              
  Lines        6346     6349       +3     
==========================================
- Hits         5937     5930       -7     
- Misses        409      419      +10     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ae879...83c092c. Read the comment docs.

Copy link

github-actions bot commented Feb 14, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 0.967 ± 0.004 (s=498) 0.967 ± 0.004 (s=435) -0.1% .. +0.1%
Slab interpolation curved simple none 0.971 ± 0.005 (s=444) 0.970 ± 0.004 (s=486) -0.2% .. +0.0%
Spherical slab interpolation simple none 1.070 ± 0.006 (s=417) 1.070 ± 0.007 (s=427) -0.1% .. +0.2%
Slab interpolation simple curved CMS 1.013 ± 0.004 (s=475) 1.012 ± 0.004 (s=417) -0.2% .. +0.0%
Spherical slab interpolation simple CMS 1.331 ± 0.008 (s=340) 1.332 ± 0.008 (s=338) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.076 ± 0.007 (s=412) 1.076 ± 0.007 (s=427) -0.2% .. +0.1%
Cartesian min max surface 2.167 ± 0.023 (s=194) 2.167 ± 0.020 (s=224) -0.3% .. +0.3%
Spherical min max surface 6.911 ± 0.026 (s=71) 6.923 ± 0.033 (s=62) -0.1% .. +0.4%

Copy link
Contributor

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions for improvements. Good otherwise.

doc/sphinx/user_manual/installation/included.md Outdated Show resolved Hide resolved
doc/sphinx/user_manual/installation/included.md Outdated Show resolved Hide resolved
@MFraters MFraters merged commit 3bb11ca into GeodynamicWorldBuilder:main Feb 15, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants