Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwb-grid: use threads by default #587

Merged

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 14, 2024

I did not benchmark if this is a good choice, but it is certainly faster than 1 thread. I happy to use something simpler (hardware_concurrency should be fine as well).

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (30ae879) 93.55% compared to head (5b4176c) 93.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   93.55%   93.40%   -0.16%     
==========================================
  Files          92       92              
  Lines        6346     6349       +3     
==========================================
- Hits         5937     5930       -7     
- Misses        409      419      +10     
Files Coverage Δ
source/gwb-grid/main.cc 46.74% <50.00%> (+0.45%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ae879...5b4176c. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.023 ± 0.004 (s=455) 0.971 ± 0.073 (s=450) -6.1% .. -3.9%
Slab interpolation curved simple none 1.026 ± 0.004 (s=461) 0.970 ± 0.003 (s=442) -5.5% .. -5.4%
Spherical slab interpolation simple none 1.260 ± 0.004 (s=381) 1.071 ± 0.005 (s=395) -15.1% .. -14.9%
Slab interpolation simple curved CMS 1.099 ± 0.002 (s=441) 1.011 ± 0.004 (s=413) -8.1% .. -8.0%
Spherical slab interpolation simple CMS 1.857 ± 0.007 (s=278) 1.331 ± 0.006 (s=292) -28.5% .. -28.3%
Spherical fault interpolation simple none 1.269 ± 0.004 (s=400) 1.076 ± 0.008 (s=367) -15.3% .. -15.1%
Cartesian min max surface 2.383 ± 0.022 (s=194) 2.165 ± 0.022 (s=205) -9.5% .. -8.9%
Spherical min max surface 7.377 ± 0.271 (s=64) 6.916 ± 0.039 (s=64) -7.8% .. -4.6%

Copy link
Contributor

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, and the benchmarks seem to agree. I will let @MFraters take another look.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The benchmarks definitely seem to like this. I also like that is show the default when using --help

@MFraters MFraters merged commit 0cd9575 into GeodynamicWorldBuilder:main Feb 14, 2024
30 of 34 checks passed
@tjhei tjhei deleted the gwb-grid-default-parallel branch February 15, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants