Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwb-grid: support for filtering cells #585

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 14, 2024

Add a new option --by-tag that enables filtering of cells inside gwb-grid. To actually do something useful, we need support inside GWB to provide tag information. So, right now, this option randomly selects some cells to be shown.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (684b28a) 93.11% compared to head (9197223) 92.56%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   93.11%   92.56%   -0.56%     
==========================================
  Files          92       92              
  Lines        6334     6375      +41     
==========================================
+ Hits         5898     5901       +3     
- Misses        436      474      +38     
Files Coverage Δ
source/gwb-grid/main.cc 44.55% <10.86%> (-2.44%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684b28a...9197223. Read the comment docs.

Copy link

github-actions bot commented Feb 15, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.014 ± 0.007 (s=463) 1.014 ± 0.004 (s=427) -0.0% .. +0.2%
Slab interpolation curved simple none 1.016 ± 0.003 (s=457) 1.015 ± 0.005 (s=432) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.167 ± 0.006 (s=371) 1.169 ± 0.005 (s=402) +0.0% .. +0.3%
Slab interpolation simple curved CMS 1.058 ± 0.007 (s=417) 1.055 ± 0.006 (s=437) -0.4% .. -0.1%
Spherical slab interpolation simple CMS 1.549 ± 0.009 (s=295) 1.549 ± 0.010 (s=288) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.171 ± 0.006 (s=394) 1.172 ± 0.008 (s=377) -0.0% .. +0.2%
Cartesian min max surface 2.311 ± 0.026 (s=208) 2.308 ± 0.024 (s=184) -0.5% .. +0.2%
Spherical min max surface 7.227 ± 0.033 (s=70) 7.230 ± 0.026 (s=57) -0.2% .. +0.3%

@tjhei
Copy link
Contributor Author

tjhei commented Feb 15, 2024

This is ready for review @MFraters

@tjhei tjhei changed the title gwb-grid: support for filtering cells [wip] gwb-grid: support for filtering cells Feb 16, 2024
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about the structure, but that is probably because it is not actually using the tags yet. I think it is probably best to merge it as is, and then we can discuss those things when it is ready to do the actual filtering.

@MFraters
Copy link
Member

Or do you want to do everthing in this pull request, given that it is still marked as [wip]?

@tjhei
Copy link
Contributor Author

tjhei commented Feb 16, 2024

Let me make a few updates...

@tjhei tjhei changed the title [wip] gwb-grid: support for filtering cells gwb-grid: support for filtering cells Feb 16, 2024
Add a new option --by-tag that enables filtering of cells inside
gwb-grid. To actually do something useful, we need support inside GWB to
provide tag information. So, right now, this option randomly selects
some cells to be shown.

fix warning

fix bugs
@tjhei
Copy link
Contributor Author

tjhei commented Feb 16, 2024

Okay, this is now ready to review and merge. I do not advertise the new option in --help yet, because it only filters tag -1 for now. I will follow up with additional PRs later. @MFraters

@MFraters MFraters merged commit 2d07a63 into GeodynamicWorldBuilder:main Feb 16, 2024
31 of 34 checks passed
@tjhei tjhei deleted the gwb-grid-filter branch February 16, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants