-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gwb-grid: support for filtering cells #585
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
- Coverage 93.11% 92.56% -0.56%
==========================================
Files 92 92
Lines 6334 6375 +41
==========================================
+ Hits 5898 5901 +3
- Misses 436 474 +38
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
This is ready for review @MFraters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about the structure, but that is probably because it is not actually using the tags yet. I think it is probably best to merge it as is, and then we can discuss those things when it is ready to do the actual filtering.
Or do you want to do everthing in this pull request, given that it is still marked as [wip]? |
Let me make a few updates... |
642ee5d
to
d308ecf
Compare
Add a new option --by-tag that enables filtering of cells inside gwb-grid. To actually do something useful, we need support inside GWB to provide tag information. So, right now, this option randomly selects some cells to be shown. fix warning fix bugs
d308ecf
to
9197223
Compare
Okay, this is now ready to review and merge. I do not advertise the new option in |
Add a new option --by-tag that enables filtering of cells inside gwb-grid. To actually do something useful, we need support inside GWB to provide tag information. So, right now, this option randomly selects some cells to be shown.