-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer manual for making a pull request #567
Add developer manual for making a pull request #567
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 92 92
Lines 6343 6343
=======================================
Hits 5934 5934
Misses 409 409 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a fourth step that says address the comments that were brought up during the review? Just to make users aware this is not done after opening the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concise. I like it!
Add steps to fork, make changes on a branch, and open pull requests to contribute to the GWB.