Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental canceling of tester runs #566

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

gassmoeller
Copy link
Contributor

Fix a mistake introduced in #561. Because benchmarks and tests had the same 'group' one of the two workflows would be cancelled if the other was running. Give them two different tags to distinguish between them.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c5e302) 93.55% compared to head (bf5a404) 93.55%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          92       92           
  Lines        6343     6343           
=======================================
  Hits         5934     5934           
  Misses        409      409           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5e302...bf5a404. Read the comment docs.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 14, 2024
@MFraters MFraters merged commit 1337ec5 into GeodynamicWorldBuilder:main Feb 14, 2024
33 of 34 checks passed
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.025 ± 0.003 (s=416) 1.026 ± 0.003 (s=464) -0.0% .. +0.1%
Slab interpolation curved simple none 1.028 ± 0.004 (s=442) 1.026 ± 0.003 (s=437) -0.3% .. -0.2%
Spherical slab interpolation simple none 1.272 ± 0.008 (s=347) 1.271 ± 0.009 (s=363) -0.2% .. +0.1%
Slab interpolation simple curved CMS 1.097 ± 0.003 (s=411) 1.099 ± 0.002 (s=411) +0.1% .. +0.2%
Spherical slab interpolation simple CMS 1.863 ± 0.005 (s=237) 1.861 ± 0.006 (s=249) -0.2% .. -0.0%
Spherical fault interpolation simple none 1.276 ± 0.004 (s=377) 1.274 ± 0.004 (s=331) -0.3% .. -0.1%
Cartesian min max surface 2.390 ± 0.017 (s=188) 2.389 ± 0.021 (s=191) -0.3% .. +0.2%
Spherical min max surface 7.391 ± 0.020 (s=63) 7.389 ± 0.016 (s=61) -0.2% .. +0.1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants