Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform fault cookbook #563

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

jdannberg
Copy link
Contributor

Cookbook for making a transform fault and creating an initial condition for ASPECT.
This still has a WIP label because ideally we would wan to link to the corresponding ASPECT cookbook as well (which I haven't created yet).

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c5e302) 93.55% compared to head (053f42e) 93.55%.
Report is 46 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          92       92           
  Lines        6343     6346    +3     
=======================================
+ Hits         5934     5937    +3     
  Misses        409      409           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5e302...053f42e. Read the comment docs.

@jdannberg jdannberg changed the title [WIP] add transform fault cookbook Add transform fault cookbook Feb 14, 2024
Copy link

github-actions bot commented Feb 14, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.022 ± 0.006 (s=437) 1.021 ± 0.003 (s=447) -0.2% .. +0.0%
Slab interpolation curved simple none 1.031 ± 0.006 (s=434) 1.031 ± 0.005 (s=441) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.264 ± 0.005 (s=349) 1.263 ± 0.005 (s=366) -0.1% .. +0.1%
Slab interpolation simple curved CMS 1.098 ± 0.009 (s=406) 1.097 ± 0.007 (s=417) -0.3% .. +0.1%
Spherical slab interpolation simple CMS 1.862 ± 0.006 (s=229) 1.858 ± 0.007 (s=257) -0.3% .. -0.1%
Spherical fault interpolation simple none 1.269 ± 0.011 (s=334) 1.268 ± 0.004 (s=378) -0.3% .. +0.1%
Cartesian min max surface 2.379 ± 0.017 (s=190) 2.377 ± 0.017 (s=191) -0.3% .. +0.2%
Spherical min max surface 7.348 ± 0.017 (s=63) 7.346 ± 0.016 (s=62) -0.1% .. +0.1%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for writing this! The only comment I have is if you could split the lines a bit more, because now you have to scroll a lot to the side in the html documentation.

@jdannberg
Copy link
Contributor Author

Thank you! I addressed your comments and also added a changelog entry.

I also made the corresponding ASPECT pull request, which can be found here: geodynamics/aspect#5575.

@jdannberg
Copy link
Contributor Author

I fixed the changelog entry

@gassmoeller gassmoeller merged commit 30ae879 into GeodynamicWorldBuilder:main Feb 14, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants