-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transform fault cookbook #563
Add transform fault cookbook #563
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 92 92
Lines 6343 6346 +3
=======================================
+ Hits 5934 5937 +3
Misses 409 409 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
7c42942
to
441404b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for writing this! The only comment I have is if you could split the lines a bit more, because now you have to scroll a lot to the side in the html documentation.
Thank you! I addressed your comments and also added a changelog entry. I also made the corresponding ASPECT pull request, which can be found here: geodynamics/aspect#5575. |
I fixed the changelog entry |
30ae879
into
GeodynamicWorldBuilder:main
Cookbook for making a transform fault and creating an initial condition for ASPECT.
This still has a WIP label because ideally we would wan to link to the corresponding ASPECT cookbook as well (which I haven't created yet).