-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update interpolation argument documentation #549
update interpolation argument documentation #549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment, otherwise good to go.
"distance parameter. Options are global, none, linear, monotone spline and " | ||
"continuous monotone spline interpolation. If this " | ||
"distance parameter. Options are 'global' and " | ||
"'continuous monotone spline' interpolation. If this " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a note here that this parameter is deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this because the global one is also only "continuous monotone spline"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and I probably want to get rid of this option before the 1.0 release.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 93.49% 93.55% +0.05%
==========================================
Files 92 92
Lines 6346 6343 -3
==========================================
+ Hits 5933 5934 +1
+ Misses 413 409 -4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
f7f20a8
to
9a62a04
Compare
updated. |
also see #547