Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gwb dat check if line is empty #519

Merged

Conversation

MFraters
Copy link
Member

@danieldouglas92 reported tan issue where the .dat file caused a segmentation fault. It turned out to be due to empty lines. This pull request fixes that issue and add some empty lines to an existing test to make sure we catch it in the future.

@MFraters MFraters added the bug Something isn't working label Nov 21, 2023
Copy link

github-actions bot commented Nov 21, 2023

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.018 ± 0.007 (s=456) 1.017 ± 0.007 (s=431) -0.2% .. +0.1%
Slab interpolation curved simple none 1.028 ± 0.005 (s=435) 1.028 ± 0.005 (s=443) -0.2% .. +0.0%
Spherical slab interpolation simple none 1.265 ± 0.010 (s=366) 1.263 ± 0.004 (s=349) -0.2% .. +0.1%
Slab interpolation simple curved CMS 1.098 ± 0.005 (s=425) 1.099 ± 0.008 (s=397) -0.1% .. +0.2%
Spherical slab interpolation simple CMS 1.863 ± 0.007 (s=237) 1.863 ± 0.008 (s=248) -0.1% .. +0.1%
Spherical fault interpolation simple none 1.274 ± 0.007 (s=361) 1.275 ± 0.010 (s=348) -0.1% .. +0.2%
Cartesian min max surface 2.418 ± 0.016 (s=195) 2.417 ± 0.019 (s=180) -0.3% .. +0.2%
Spherical min max surface 7.379 ± 0.034 (s=74) 7.372 ± 0.013 (s=51) -0.3% .. +0.1%

@MFraters MFraters force-pushed the gwb-dat_check_if_line_is_empty branch from c0e1e3e to e642a04 Compare November 21, 2023 20:22
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #519 (e642a04) into main (78f1200) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          92       92           
  Lines        6279     6279           
=======================================
  Hits         5868     5868           
  Misses        411      411           
Files Coverage Δ
source/gwb-dat/main.cc 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f1200...e642a04. Read the comment docs.

@MFraters MFraters merged commit 41ddcc5 into GeodynamicWorldBuilder:main Nov 21, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant