Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang and removed unneeded headers #295

Conversation

MFraters
Copy link
Member

This is a follow up for #293 and related to issue #294. Clean up header files with IWYU and custom script (which can be found here: https://stackoverflow.com/a/7135530) which goes through all the files and removes the includes one by one. This is has been a bit messy and a lot of checking and fixing by hand, but the final result is an improvement. So I am not going to include the codes I used to do this in the pull request for now.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #295 (16142c5) into master (bdb5458) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 16142c5 differs from pull request most recent head f50d0c6. Consider uploading reports for the commit f50d0c6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          74       74           
  Lines        4228     4228           
=======================================
  Hits         4186     4186           
  Misses         42       42           
Impacted Files Coverage Δ
app/main.cc 97.43% <ø> (ø)
source/coordinate_systems/cartesian.cc 100.00% <ø> (ø)
source/coordinate_systems/interface.cc 100.00% <ø> (ø)
source/coordinate_systems/spherical.cc 100.00% <ø> (ø)
source/features/continental_plate.cc 100.00% <ø> (ø)
.../continental_plate_models/composition/interface.cc 100.00% <ø> (ø)
...es/continental_plate_models/composition/uniform.cc 100.00% <ø> (ø)
...tures/continental_plate_models/grains/interface.cc 100.00% <ø> (ø)
...plate_models/grains/random_uniform_distribution.cc 100.00% <ø> (ø)
...eatures/continental_plate_models/grains/uniform.cc 100.00% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb5458...f50d0c6. Read the comment docs.

@MFraters MFraters force-pushed the fix_clang_and_removed_unneeded_headers branch from b1aa758 to ab34b48 Compare June 27, 2021 23:21
@github-actions
Copy link

github-actions bot commented Jun 27, 2021

Benchmark Master Feature Difference (99.9% CI)
Slab interpolation simple none 1.547 ± 0.053 (s=304) 1.546 ± 0.052 (s=281) -1.0% .. +0.8%
Slab interpolation curved simple none 1.613 ± 0.040 (s=291) 1.621 ± 0.038 (s=268) -0.2% .. +1.1%
Spherical slab interpolation simple none 2.172 ± 0.023 (s=205) 2.177 ± 0.019 (s=211) -0.1% .. +0.5%
Slab interpolation simple curved CMS 1.780 ± 0.003 (s=258) 1.791 ± 0.004 (s=249) +0.6% .. +0.7%
Spherical slab interpolation simple CMS 4.192 ± 0.065 (s=101) 4.198 ± 0.082 (s=116) -0.6% .. +1.0%
Spherical fault interpolation simple none 2.641 ± 0.078 (s=172) 2.650 ± 0.076 (s=171) -0.7% .. +1.4%

@MFraters MFraters force-pushed the fix_clang_and_removed_unneeded_headers branch 2 times, most recently from 19060dc to 57789d0 Compare June 28, 2021 00:58
@MFraters MFraters force-pushed the fix_clang_and_removed_unneeded_headers branch from 57789d0 to 9dbe268 Compare June 28, 2021 03:42
@MFraters MFraters force-pushed the fix_clang_and_removed_unneeded_headers branch from 9dbe268 to f50d0c6 Compare June 28, 2021 04:11
@MFraters MFraters merged commit 5541dd2 into GeodynamicWorldBuilder:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant