Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whakatane camera from cabinet and put on pole #953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove whakatane camera from cabinet and put on pole #953

wants to merge 2 commits into from

Conversation

Camasher
Copy link
Contributor

No description provided.

@Camasher Camasher self-assigned this Nov 24, 2020
rumachan
rumachan requested changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@rumachan rumachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an image from the pole mounted camera at 05:20, yet the new start time is listed as 05:50. Can you correct this please.

@Camasher Camasher requested a review from rumachan December 8, 2020 22:05
rumachan
rumachan previously approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@rumachan rumachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Camasher
Copy link
Contributor Author

Camasher commented Feb 3, 2021

@rumachan @JonoHanson ready to merge, I dont have delta merge permissions

@rumachan
Copy link
Contributor

I don't understand how to deal with this

@ozym ozym removed request for ozym and JonoHanson July 11, 2022 22:37
@ozym ozym force-pushed the Camasher-WHWI-camera_movement branch from 2ff01d3 to 74fa8d3 Compare August 26, 2022 01:58
@ozym
Copy link
Contributor

ozym commented Aug 26, 2022

@rumachan @Camasher I have updated the PR (some old house keeping) to switch the camera code and add the 02 mount. I don't see any problems, but would be good to get another tick.

@rumachan
Copy link
Contributor

Checks have passed so didn't do a review.
Checked the images in the archive and they match the time of change in the PR, so all go.

Thanks for dragging this out of the back cupboard @ozym

@ozym ozym force-pushed the Camasher-WHWI-camera_movement branch from dc387e3 to 21e6803 Compare August 30, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumachan rumachan rumachan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rumachan rumachan

@Camasher Camasher

@JonoHanson JonoHanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Camasher @rumachan @ozym @JonoHanson @salichon