Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ecr env var to avoid clash #318

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: change ecr env var to avoid clash #318

merged 1 commit into from
Sep 6, 2024

Conversation

Mossman1215
Copy link
Contributor

@Mossman1215 Mossman1215 commented Sep 6, 2024

this was supposed to allow dry-run vs run on main but got this error
Error: authenticating creds for true: pinging container registry true: Get https://true/v2/: dial tcp: lookup true: Temporary failure in name resolution

my mistake

this was supposed to allow dry-run vs run on main but got this error Error: authenticating creds for true: pinging container registry true: Get https://true/v2/: dial tcp: lookup true: Temporary failure in name resolution
@Mossman1215 Mossman1215 requested a review from ardrigh September 6, 2024 03:40
Copy link
Contributor

@ardrigh ardrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, rolling forward is good

@ardrigh ardrigh merged commit 81febdf into main Sep 6, 2024
14 checks passed
@ardrigh ardrigh deleted the hotfix-ecr-login branch September 6, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants