Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: suppress warnings for invalid url source #304

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: suppress warnings for invalid url source #304

merged 1 commit into from
Aug 22, 2024

Conversation

raki-git
Copy link
Contributor

@raki-git raki-git commented Aug 21, 2024 •
edited
Loading

suppress warnings for invalid url source and removing centos7 images as we won't be using it anymore

[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ rpmlint seiscomp/
=========================================================================================================== rpmlint session starts ===========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

seiscomp.spec: W: invalid-url Source0: seiscomp-6.3.1-rhel-8-x86_64.tar.gz
====================================================================== 0 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 filtered, 0 badness; has taken 0.1 s ======================================================================
[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ 

[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ rpmlint caps-plugins/
=========================================================================================================== rpmlint session starts ===========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

caps-plugins.spec: W: invalid-url Source0: caps-plugins-2024.066-seiscomp-6-rhel-8-x86_64.tar.gz
====================================================================== 0 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 filtered, 0 badness; has taken 0.1 s ======================================================================
[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$

linked to https://github.com/GeoNet/packaging/pull/367

@raki-git raki-git force-pushed the rpmlintrc branch 13 times, most recently from 3974c39 to 7e98d96 Compare August 21, 2024 23:11
@raki-git raki-git requested a review from Mossman1215 August 21, 2024 23:15
@raki-git raki-git added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 21, 2024
@raki-git
Copy link
Contributor Author

Test outcome

[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ cat /etc/xdg/rpmlint/rpmlintrc.toml
#suppress warnings for invalid-url Source

Filters = ['W: invalid-url Source*']
[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$

[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ rpmlint  seiscomp/
=========================================================================================================== rpmlint session starts ===========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/rpmlintrc.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

====================================================================== 0 packages and 1 specfiles checked; 0 errors, 0 warnings, 1 filtered, 0 badness; has taken 0.1 s ======================================================================
[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ 

[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$ rpmlint caps-plugins/
=========================================================================================================== rpmlint session starts ===========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/rpmlintrc.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

====================================================================== 0 packages and 1 specfiles checked; 0 errors, 0 warnings, 1 filtered, 0 badness; has taken 0.1 s ======================================================================
[rakid@hutl24194:~/GEO_Workspae/packaging/inputs/el8]$

ardrigh
ardrigh approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ardrigh ardrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New configuration file is very useful

Mossman1215
Mossman1215 reviewed Aug 21, 2024
View reviewed changes
images/rpmbuild-centos7/rpmlintrc.toml Outdated
@@ -0,0 +1,3 @@
#suppress warnings for invalid-url Source0

Filters = ['W: invalid-url Source*']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't be keeping centos7 images now and this should have been removed already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mossman1215 just removed centos7 image

@raki-git
fix: suppress warnings for invalid url source
3a7f7ca 
suppress warnings for invalid url source
@raki-git raki-git requested a review from Mossman1215 August 21, 2024 23:39
Mossman1215
Mossman1215 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Mossman1215 Mossman1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.
let's see if it resolves the linter implementation

@ardrigh ardrigh merged commit 31755d6 into main Aug 22, 2024
24 of 25 checks passed
@ardrigh ardrigh deleted the rpmlintrc branch August 22, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossman1215 Mossman1215 Mossman1215 approved these changes

@ardrigh ardrigh ardrigh approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raki-git @ardrigh @Mossman1215