-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow use of consistent container tagging #271
Conversation
aea31df
to
db10d2d
Compare
I would recommend putting the date timestamp field first, adding That would look like This aligns it with the packaging tags using |
The build id was to allow, for a given image, what version of Anyway, I'm happy to drop build id from the default tag, if it's not useful, as the end user can add build id themselves to their tagging scheme if they really needed it. An alternative would be to have build id as an option behind some sort of
That looks good, I'll make the change, thanks. |
Adds ability to generate consistent container tag across workflows.
db10d2d
to
1170d31
Compare
- name: Generate tags | ||
id: tags | ||
env: | ||
RELEVANT_SHA: ${{ github.event.pull_request.head.sha || github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what scenarios does the || github.sha
account for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most commonly, it accounts for push to main, which typically happens on PR merge; github.sha
will be the last commit of main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Motivating ticket: https://github.com/GeoNet/tickets/issues/14398
This PR adds a composite action providing a consistent tag, or at least, consistent outputs to construct such a tag.
This should be suitable for use in the reusable workflows, as well as explicitly within users own workflow jobs.
Currently, the proposed format is commit sha-timestamp-build id...for example,
1da9c71-20240515111413-9094587538
Points to consider are: