Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ko-build tests #199

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: add ko-build tests #199

merged 1 commit into from
Oct 17, 2023

Conversation

BobyMCbobs
Copy link
Contributor

test ko build functions

@BobyMCbobs BobyMCbobs force-pushed the add-ko-build-tests branch 8 times, most recently from 211f56a to 587ebe5 Compare October 2, 2023 01:31
@BobyMCbobs BobyMCbobs requested a review from a team October 8, 2023 19:39
ozym
ozym previously approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@ozym ozym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, noted about retries.

@BobyMCbobs BobyMCbobs force-pushed the add-ko-build-tests branch 7 times, most recently from bfc3f36 to 7b3d47c Compare October 17, 2023 20:55
@BobyMCbobs
Copy link
Contributor Author

currently updating the tests given some small new features like configPath and adding a test for the expected base images

@BobyMCbobs BobyMCbobs force-pushed the add-ko-build-tests branch 6 times, most recently from eba8b39 to e3ac7f3 Compare October 17, 2023 21:35
@BobyMCbobs
feat: add ko-build tests
276ead5 
test ko build functions
@BobyMCbobs BobyMCbobs requested a review from ozym October 17, 2023 21:52
@BobyMCbobs
Copy link
Contributor Author

@ozym, thank you for your earlier review. Needed to make some changes and now got the tests to pass.

added a test for config and base images, and a fixed some behaviours

ozym
ozym approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ozym ozym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see tests

@BobyMCbobs BobyMCbobs merged commit 9502d9c into main Oct 17, 2023
@BobyMCbobs BobyMCbobs deleted the add-ko-build-tests branch October 17, 2023 22:22
@BobyMCbobs
Copy link
Contributor Author

@ozym, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozym ozym ozym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobyMCbobs @ozym