Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a working GitHub Actions config (for CI builds) #173

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

janusw
Copy link
Member

@janusw janusw commented Jan 4, 2024

This PR updates the existing GHA config so that it triggers CI jobs for pushes to all branches and all PRs.

You can see a working GHA build based on this branch in my fork: https://github.com/janusw/GeoJSON.Net/actions/runs/7409092782

One can certainly add further extensions to this, but I'm deliberately sticking to the bare minimum that is necessary for triggering successful CI builds here (without any actual source-code changes), so that one has a baseline for further changes.

@xfischer @matt-lethargic Is this ok with you?

janusw added 3 commits January 4, 2024 11:22
* and add a manual trigger
* previously one got errors like this:

MSBUILD : error MSB1003: Specify a project or solution file.
The current working directory does not contain a project or solution file.
* in addition to .NET Core 3.1
* and use the latest version of the 'setup-dotnet' action
@janusw
Copy link
Member Author

janusw commented Feb 11, 2024

Ping! Is this repo dead? Can I help with maintenance? Or do I need to fork?

@xfischer xfischer merged commit 7cc00fb into GeoJSON-Net:master Feb 13, 2024
@xfischer
Copy link
Member

Sorry for the delay @janusw and thanks again. Repo is not dead, but our day to day job and life leaves small space at some moments !

@xfischer
Copy link
Member

Related discussion in #167 (comment)_

@janusw janusw deleted the gha branch February 14, 2024 07:11
@janusw
Copy link
Member Author

janusw commented Feb 14, 2024

Sorry for the delay @janusw and thanks again.

Thanks for merging!

Repo is not dead, but our day to day job and life leaves small space at some moments !

I know that feeling ;)

@janusw
Copy link
Member Author

janusw commented Feb 14, 2024

Related discussion in #167 (comment)_

Yes, now that this issue is out of the way (and the tests are automatically run as part of the CI), I'm going to return to #167 and finish it up by adding a test case.

@matt-lethargic
Copy link
Member

matt-lethargic commented Feb 18, 2024

Hey @janusw sorry about any delay, I've not been able to look at this due to my day job.

Thanks @xfischer for looking at this. Maybe it's time to for me to step aside and look for a new maintainer :-/

@janusw
Copy link
Member Author

janusw commented Feb 18, 2024

Thanks @xfischer for looking at this.

+1

Maybe it's time to for me to step aside and look for a new maintainer :-/

Well, I can offer to help out with maintenance a bit, and support @xfischer in this task (if that is desired).

Currently you guys are certainly not living up to the promise given in the README ;)

We try and review most pull requests within a couple of days.

Fortunately it seems like this library is rather stable and does not need a huge amount of maintenance (which is a bit in contrast to the fact that all the latest releases on nuget.org have an -rc suffix).

Let me know if I can be of any help ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants