Make Feature.geometry optional (#179)

* make Feature.geometry optional

* add two test cases
* deserializing a feature with NULL geometry
* deserializing a feature without any geometry
* the resulting feature object is identical for both cases
* amend .gitignore
* GHA: fix some deprecation warnings

.github/workflows/main.yml

@@ -13,7 +13,7 @@ jobs:
   linuxBuild:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Setup .NET Core
@@ -32,7 +32,7 @@ jobs:
   winBuild:
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Setup .NET Core

.gitignore

@@ -8,6 +8,7 @@ node_modules
 *.csproj.user
 /TestResults
 .vscode
+.mono
 /GoCompare.CustomerPreference/CustomerPreferenceService/Service.xml
 /GoCompare.CustomerPreference/CustomerPreferenceService/Properties/PublishProfiles/CustomerPreferenceService - Web Deploy.pubxml
 /GoCompare.CustomerPreference/CustomerPreferenceService/Properties/PublishProfiles/CustomerPreferenceService - Web Deploy.pubxml.user

src/GeoJSON.Net.Tests/Feature/FeatureTests.cs

@@ -43,6 +43,38 @@ public void Can_Deserialize_Feature_Without_Props()
             Assert.AreEqual(GeoJSONObjectType.Polygon, feature.Geometry.Type);
         }
 
+        [Test]
+        public void Can_Deserialize_Feature_With_Null_Geometry()
+        {
+            var json = GetExpectedJson();
+
+            var feature = JsonConvert.DeserializeObject<Net.Feature.Feature>(json);
+
+            Assert.IsNotNull(feature);
+            Assert.IsNotNull(feature.Properties);
+            Assert.IsTrue(feature.Properties.Any());
+            Assert.IsTrue(feature.Properties.ContainsKey("name"));
+            Assert.AreEqual(feature.Properties["name"], "Unlocalized Feature");
+
+            Assert.IsNull(feature.Geometry);
+        }
+
+        [Test]
+        public void Can_Deserialize_Feature_Without_Geometry()
+        {
+            var json = GetExpectedJson();
+
+            var feature = JsonConvert.DeserializeObject<Net.Feature.Feature>(json);
+
+            Assert.IsNotNull(feature);
+            Assert.IsNotNull(feature.Properties);
+            Assert.IsTrue(feature.Properties.Any());
+            Assert.IsTrue(feature.Properties.ContainsKey("name"));
+            Assert.AreEqual(feature.Properties["name"], "Unlocalized Feature");
+
+            Assert.IsNull(feature.Geometry);
+        }
+
         [Test]
         public void Can_Serialize_LineString_Feature()
         {

src/GeoJSON.Net.Tests/Feature/FeatureTests_Can_Deserialize_Feature_With_Null_Geometry.json

@@ -0,0 +1,7 @@
+{
+  "type": "Feature",
+  "geometry": null,
+  "properties": {
+    "name": "Unlocalized Feature"
+  }
+}

src/GeoJSON.Net.Tests/Feature/FeatureTests_Can_Deserialize_Feature_Without_Geometry.json

@@ -0,0 +1,6 @@
+{
+  "type": "Feature",
+  "properties": {
+    "name": "Unlocalized Feature"
+  }
+}

src/GeoJSON.Net/Feature/Feature.cs

@@ -35,7 +35,7 @@ public Feature(TGeometry geometry, TProps properties, string id = null)
         [JsonProperty(PropertyName = "id", NullValueHandling = NullValueHandling.Ignore)]
         public string Id { get; }
 
-        [JsonProperty(PropertyName = "geometry", Required = Required.AllowNull)]
+        [JsonProperty(PropertyName = "geometry", Required = Required.Default)]
         [JsonConverter(typeof(GeometryConverter))]
         public TGeometry Geometry { get; }