Always translate home into meta+enter #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA: SYSTEM-2682
Home widget button is broken on ARM SaaS which uses a PaaS image, as desktop & paas images handle the home button differently.
First, the Android documentation for the actual mapping between linux keyboard keycodes and Android keycodes tells us:
KEY_HOMEPAGE
(Qt::Key_HomePage
) maps to Android KEYCODE_HOME and is the physical home button (back to "desktop")KEY_HOME
(Qt::Key_Home
) maps to Android KEYCODE_MOVE_HOME and isHistorically, it seems that the desktop image maps
KEYCODE_MOVE_HOME
toKEYCODE_HOME
, indevice/genymotion/vbox86/Genymotion_Virtual_Input.kl
, so the SaaS web player mapped the home widget to this button.Now, the PaaS image does not have this mapping (it is not necessary), so the webplayer has an option to translate this button to Meta+Enter, which is a shortcut for the home button.
However, this results in the Paas in Saas configuration being broken, as the SaaS web player sends (ultimately, through webrtcd mapping & redis) the
KEYCODE_MOVE_HOME
to the PaaS image.This fix:
KEY_HOMEPAGE
, as it is more accurate, even though it ends up being translated. We could later remove the translation, when webrtcd is aware of this keycode.Fixes SYSTEM-2682
Type of change
Checklist