Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework webrtc reconnection #109

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Rework webrtc reconnection #109

wants to merge 4 commits into from

Conversation

pgivel
Copy link
Contributor

@pgivel pgivel commented Sep 24, 2024 •
edited
Loading

Description

  • Add a clean reconnection function in DeviceRenderer that also calls the store to reconnect
  • In the store, retrigger all bound callbacks
  • Make reconnection available in API

related to #108

@pgivel pgivel self-assigned this Sep 24, 2024
pgivel
pgivel commented Sep 24, 2024
View reviewed changes
src/DeviceRenderer.js Outdated Show resolved Hide resolved
@pgivel
Add reconnect function
d4c7480 
that disconnects and restart webrtc connection
and also rebinds input listeners
@pgivel pgivel force-pushed the dev/fix-inputs-on-connection-restart branch from 541d779 to d4c7480 Compare September 25, 2024 09:50
@pgivel pgivel changed the title wip Rework webrtc reconnection Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparez jparez jparez left review comments

Assignees

@pgivel pgivel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgivel @jparez