-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to Vue 3 #263
switch to Vue 3 #263
Conversation
We may want to have a switch to chose the Vue version. Therefore I kept the old vue.js and vue.min.js in place. |
Seems that the watchers solution doesn't work any longer, I'll dig a bit deeper. |
I finally solved the watcher problem with this hint: vuejs/vue#1829 (comment). |
Finally moved the numberformat filter to a mixin, so we should be set. |
looks good @hhaensel I read "vue2 is dead" few days ago. I was worried about this myself :) |
This PR works successfully with StippleUI#hh-vue3 and the latest Quasar 2, so the PR is open for review 😄 |
…support compatibility for Quasar2 Tables
* precompile ReactiveTools App to reduce ttfx * optionally set port for or entirely switch off precompilation of `get()` by setting `ENV["STIPPLE_PRECOMPILE_PORT"]` (e.g. `8081`) or `ENV["STIPPLE_PRECOMPILE_GET"]` (e.g. `1`, `0`, `true`, `false`)
This is the next effort to switch to Vue 3
I've built on top of previous commits by @AbhimanyuAryan and @essenciary, I included a new version for
$withoutWatchers()
from vuejs/vue#1829 (comment) and went through some additional migration changes.This version seems to work. I've not yet fully tested all details of the watcher but it's a next step.
The only part that I could not solve are the two components dashboard and big-numbers in stipplecore.js.
It seems that
Vue.component()
needs to be replaced byapp.component()
or in our casewindow.GENIEMODEL.component()
, however, at the point where this is called, the app has not yet been created.@essenciary I think you should be pretty quick in finding the correct place to move these definitions to.
Happy to continue the Vue-3 journey. Next step is certainly Quasar-2 😄 - finally!