Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Vue 3 #263

Merged
merged 44 commits into from
May 3, 2024
Merged

switch to Vue 3 #263

merged 44 commits into from
May 3, 2024

Conversation

hhaensel
Copy link
Member

This is the next effort to switch to Vue 3

I've built on top of previous commits by @AbhimanyuAryan and @essenciary, I included a new version for $withoutWatchers() from vuejs/vue#1829 (comment) and went through some additional migration changes.
This version seems to work. I've not yet fully tested all details of the watcher but it's a next step.

The only part that I could not solve are the two components dashboard and big-numbers in stipplecore.js.
It seems that Vue.component() needs to be replaced by app.component() or in our case window.GENIEMODEL.component(), however, at the point where this is called, the app has not yet been created.

@essenciary I think you should be pretty quick in finding the correct place to move these definitions to.

Happy to continue the Vue-3 journey. Next step is certainly Quasar-2 😄 - finally!

@hhaensel
Copy link
Member Author

We may want to have a switch to chose the Vue version. Therefore I kept the old vue.js and vue.min.js in place.

@hhaensel
Copy link
Member Author

Seems that the watchers solution doesn't work any longer, I'll dig a bit deeper.

@hhaensel
Copy link
Member Author

hhaensel commented Feb 12, 2024

I finally solved the watcher problem with this hint: vuejs/vue#1829 (comment).
Should be even faster than the previous solution as we have direct ignoreUpdates functions for each watcher and don't have to filter the array of existing watchers for the name.
Moreover, we can remove the manual addition of expressions to the watchers in prod-mode.

@hhaensel
Copy link
Member Author

Finally moved the numberformat filter to a mixin, so we should be set.

@AbhimanyuAryan
Copy link
Member

looks good @hhaensel I read "vue2 is dead" few days ago. I was worried about this myself :)

@hhaensel hhaensel marked this pull request as ready for review February 12, 2024 20:46
@hhaensel
Copy link
Member Author

This PR works successfully with StippleUI#hh-vue3 and the latest Quasar 2, so the PR is open for review 😄

@hhaensel hhaensel merged commit 6b1a920 into master May 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants