Skip to content

Commit

Permalink
remove one failing test for version 1.6
Browse files Browse the repository at this point in the history
  • Loading branch information
hhaensel committed Oct 29, 2024
1 parent dde4d46 commit 5b924cc
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,12 @@ end

@test Stipple.stipple_parse(Union{Nothing, String}, "hi") == "hi"
@test Stipple.stipple_parse(Union{Nothing, String}, SubString("hi")) == "hi"
@test Stipple.stipple_parse(Union{Nothing, SubString}, "hi") == SubString("hi")
# the following test is only valid for Julia 1.7 and above because specifity of methods
# changed in Julia 1.7. As the latest LTS version of Julia is now 1.10, we accept that
# this specific stipple_parse for Union{Nothing, T} fails for Julia 1.6
# people can define explicit methods for their types if they need this functionality
@static if VERSION v"1.7"
@test Stipple.stipple_parse(Union{Nothing, SubString}, "hi") == SubString("hi")
end
@test Stipple.stipple_parse(Union{Nothing, String}, nothing) === nothing
end

0 comments on commit 5b924cc

Please sign in to comment.