Skip to content

Commit

Permalink
Merge pull request #247 from harleyjackthomas/fix-246-genie.default-d…
Browse files Browse the repository at this point in the history
…ocker-host

Changes to host value in generated dockerfile, updates docs
  • Loading branch information
essenciary authored Jun 9, 2020
2 parents d5df6d0 + 2404795 commit c2fe4f5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/documentation/16--Using_Genie_With_Docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Starting docker container with `docker run -it --rm -p 80:8000 --name genieapp g
Genie v0.19.0
Active env: DEV

Web Server starting at http://0.0.0.0:8000
Web Server starting at http://127.0.0.1:8000
```
Our application starts inside the Docker container, binding port 8000 within the container (where the Genie app is running) to the port 80 of the host. So we are now able to access our app at `http://localhost`. If you navigate to `http://localhost` with your favourite browser you'll see Genie's welcome page. Notice that we don't access on port 8000 - this page is served from the Docker container on the default port 80.
Expand Down
2 changes: 1 addition & 1 deletion src/Deploy.jl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Generates a `Dockerfile` optimised for containerizing Genie apps.
- `force::Bool`: if the file already exists, when `force` is `true`, it will be overwritten
"""
function dockerfile(path::String = "."; filename::String = "Dockerfile", user::String = "genie", env::String = "dev",
host = "0.0.0.0", port::Int = 8000, dockerport::Int = 80, force::Bool = false,
host = "127.0.0.1", port::Int = 8000, dockerport::Int = 80, force::Bool = false,
websockets_port::Int = 8001, websockets_dockerport::Int = 8001)
filename = normpath(joinpath(path, filename))
isfile(filename) && force && rm(filename)
Expand Down

0 comments on commit c2fe4f5

Please sign in to comment.