Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] merge entity #424

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

Kashu7100
Copy link
Collaborator

You can combine two rigid entities in a scene (can be a mixture of URDF and MJCF!).
Use case: attach a gripper to an arm, attach a manipulator to a quadruped, etc.

Example use case (Panda + Figure hand):
image

@ziyanx02
Copy link
Collaborator

ziyanx02 commented Jan 1, 2025

Well done! This will solve most of the problems! But there are some small issues here:

  1. I have to change
    "genesis/assets/urdf/panda_bullet/panda_nohand.urdf" to "urdf/panda_bullet/panda_nohand.urdf"
    "genesis/assets/urdf/panda_bullet/hand.urdf" to "urdf/panda_bullet/hand.urdf"
    to make the example work.
  2. Once the link of the child entity assigned to merge is not the root link, changing its parent link will cause the child entity seperated into two parts. But this could be a quick fix for mobile manipulation stuff.

examples/rigid/merge_entities.py Outdated Show resolved Hide resolved
@Kashu7100
Copy link
Collaborator Author

Ok, fixed the pointed part.

  1. fixed path to genesis assets
  2. set default of child link to its base and when user assigns non-base link, it will warn in logger

@Kashu7100 Kashu7100 requested a review from ziyanx02 January 1, 2025 11:21
@ziyanx02 ziyanx02 merged commit 6622ef7 into Genesis-Embodied-AI:main Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants