Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pause and reset function on Genesis #290

Closed

Conversation

JonnyDing
Copy link
Contributor


Feature Enhancement

To improve the workflow when loading robot models from URDF or XML files, I added a feature to simplify setting default joint positions:

robot.set_dofs_position(default_dof_pos, dofs_idx)

This enhancement includes a utility to validate joint positions more conveniently, reducing reliance on manual debugging.

I have implemented this feature and would like to submit a PR for your review. Feedback and suggestions are welcome! 😊


微信图片_20241224190352

@PieterBecking
Copy link
Contributor

PieterBecking commented Dec 24, 2024

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

@JonnyDing
Copy link
Contributor Author

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

@PieterBecking
Copy link
Contributor

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone

@JonnyDing
Copy link
Contributor Author

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone

@JonnyDing JonnyDing closed this Dec 24, 2024
@JonnyDing JonnyDing reopened this Dec 24, 2024
@JonnyDing
Copy link
Contributor Author

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone

Emmm I cannot find suitable key for pause function because i choose Space key is more convenient

@JonnyDing
Copy link
Contributor Author

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone
I'm using the shift button as a thrust. lol

@PieterBecking
Copy link
Contributor

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone

Emmm I cannot find suitable key for pause function because i choose Space key is more convenient

Yeah no worries I can pick another for the thrust if necessary👍

@JonnyDing
Copy link
Contributor Author

examples/drone/interactive_drone.py would have to be adjusted if the space bar would be pause. Can do that

No adjustment is needed. In the current implementation, pressing the space bar will stop the simulation, and pressing it again will resume. Additionally, the 'x' key resets the drone to its initial state.

Yes I do as space bar is thrust for the drone

Emmm I cannot find suitable key for pause function because i choose Space key is more convenient

Yeah no worries I can pick another for the thrust if necessary👍

thanks.my English is not very good。

@JonnyDing JonnyDing closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants