-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot/plot3d: Simplify the -A syntax to -Ax|y #8674
base: master
Are you sure you want to change the base?
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit f2f3f7a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt I should review this since I implemented -Am and -Ap in GMT4 in Sep 2007!
Since then it was extended with -A[x|y|r|t], without it actually requiring a change of code except for needing to parse the options and add to the documentation.
So it is OK to me to bring it back to -A[x|y] as long as the old options are still supported for backward compatibility.
How does this impact the long options?
Good to know the history dating back to 2007! When updating the documentation, we also found a bug that the meaning of
Yes, it's backward compatible.
That's a good question. Currently, long names exist for m/p/x/y/r/t ( Line 29 in 605da46
|
The original implementation from 2007 was, according to the e-mail I found about it:
As I said, So with this PR (#8674) we are good. Regarding the long options, since they have not been thoroughly introduced, I would keep only |
I must have missed that longoption choice that missed to match any of GMT.jl options. I propose to rename it to |
In PyGMT, the parameter name is |
GMT.jl accepts |
Also -E longoptions got it all wrong GMT.jl has |
See #8645 for context.
Closes #8645.