fix: minor refactoring

Gearbox-protocol · Jan 13, 2025 · c957457 · c957457
1 parent 46b1ef7
commit c957457
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/contracts/credit/CreditManagerV3.sol b/contracts/credit/CreditManagerV3.sol
@@ -1292,16 +1292,20 @@ contract CreditManagerV3 is ICreditManagerV3, SanityCheckTrait, ReentrancyGuardT
         _setCreditConfigurator(_creditConfigurator);
     }
 
+    /// @dev Same as above, added for compatibility with `BytecodeRepository` which only works with `Ownable` contracts
+    function transferOwnership(address newOwner)
+        external
+        creditConfiguratorOnly // U:[CM-4]
+    {
+        _setCreditConfigurator(newOwner);
+    }
+
+    /// @dev `setCreditConfigurator` implementation
     function _setCreditConfigurator(address _creditConfigurator) internal {
         creditConfigurator = _creditConfigurator; // U:[CM-46]
         emit SetCreditConfigurator(_creditConfigurator); // U:[CM-46]
     }
 
-    // @notice Added for compatibility with the ByteCodeRepository Deployment
-    function transferOwnership(address _creditConfigurator) external creditConfiguratorOnly {
-        _setCreditConfigurator(_creditConfigurator);
-    }
-
     // --------- //
     // INTERNALS //
     // --------- //

diff --git a/contracts/test/unit/credit/CreditManagerV3.unit.t.sol b/contracts/test/unit/credit/CreditManagerV3.unit.t.sol
@@ -540,6 +540,9 @@ contract CreditManagerV3UnitTest is TestHelper, ICreditManagerV3Events, BalanceH
 
         vm.expectRevert(CallerNotConfiguratorException.selector);
         creditManager.setCreditConfigurator(DUMB_ADDRESS);
+
+        vm.expectRevert(CallerNotConfiguratorException.selector);
+        creditManager.transferOwnership(DUMB_ADDRESS);
     }
 
     /// @dev U:[CM-5]: non-reentrant functions revert if called in reentrancy