New contact module, Surface base class and tests #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [requests](https://github.com/psf/requests) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ced to check whether the default connection indices are None
Ali-7800
added
enhancement
Ali-7800
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #281 +/- ##
================================================
+ Coverage 93.60% 93.71% +0.11%
================================================
Files 44 48 +4
Lines 3000 3055 +55
Branches 347 354 +7
================================================
+ Hits 2808 2863 +55
Misses 155 155
Partials 37 37
☔ View full report in Codecov by Sentry. |
…contact_function now
armantekinalp
requested changes
Jul 19, 2023
@Ali-7800 also can you improve the PR description. It is not clear right now. |
…ests-2.31.0 build(deps): bump requests from 2.30.0 to 2.31.0
…len_ from test_connections.py and test_contacts.py
armantekinalp
approved these changes
Jul 31, 2023
Co-authored-by: Arman Tekinalp <[email protected]>
bhosale2
requested changes
Aug 2, 2023
…order_check, and changed NoContact init doc
skim0119
reviewed
Aug 3, 2023
Co-authored-by: Seung Hyun Kim <[email protected]>
skim0119
requested changes
Aug 3, 2023
…rt of the message
…tem_collection_with_connections_and_indices
added -> None: Co-authored-by: Yashraj Bhosale <[email protected]>
Co-authored-by: Yashraj Bhosale <[email protected]>
Co-authored-by: Yashraj Bhosale <[email protected]>
Co-authored-by: Yashraj Bhosale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contact module PR. Contact module will be used for contact between system_type objects (rods and rigid bodies) and allowed_contact_type objects (rods, rigid bodies and surfaces). This PR includes: