Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added settings_errors() to GatherPress settings template. #520

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Jan 28, 2024

Description of the Change

GatherPress Settings page was not showing Settings saved. or any kind of message after saving. This change adds that messaging.

Screenshot 2024-01-28 at 9 50 31 AM

Closes #510

How to test the Change

Go to Events -> Settings and save. Message will appear now.

Changelog Entry

N/A

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri merged commit 3cc3738 into main Jan 28, 2024
10 checks passed
@mauteri mauteri deleted the GP-510 branch January 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Settings saved." notification after saving Events -> Settings
1 participant