Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #398

Closed
wants to merge 22 commits into from
Closed

Dependency updates #398

wants to merge 22 commits into from

Conversation

ianroberts
Copy link
Member

Merging #397 to master to close Dependabot alerts.

- vite 4.2.1 -> 4.5.2 (supersedes dependabot PR #396)
- vitest 0.30.1 -> 0.34.6 [note 1]
- vue 2.7.14 -> 2.7.16
- vue-router 3.2.0 -> 3.6.5
- vue-template-compiler 2.6.11 -> 2.7.16 (to match Vue itself)
- vuex 3.4.0 -> 3.6.2
- cypress 12.9.0 -> 12.17.4

[1]: we can't upgrade to vitest v1.x without first upgrading to vite v5, but that is not currently compatible with Cypress
It's infuriating when the test fails in CI but not when I run it locally
@ianroberts ianroberts requested a review from twinkarma January 21, 2024 20:21
Copy link

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 83.8 83.96 64 83.8
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 83.8 83.96 64 83.8
_jrpc 94.11 91.66 83.33 94.11
_ index.js 94.11 91.66 83.33 94.11 29-30,38-40
_utils 81.97 82.97 57.89 81.97
_ annotations.js 97.72 73.91 100 97.72 35-36
_ dict.js 88.88 83.33 100 88.88 3-4
_ expressions.js 80.08 82.35 80 80.08 ...,188-190,201-218
_ index.js 73.6 100 14.28 73.6 ...4-65,76-82,93-94

@ianroberts
Copy link
Member Author

I think the initial integration test failure was just the actions runner being slow and something timing out - the cypress tests do seem to run a lot slower on CI than they do locally.

ianroberts and others added 11 commits February 23, 2024 13:28
Add a "teamware_status" section to the export formats detailing which users (if any) have rejected, aborted or timed out annotations on each document.

- for "raw" JSON this is a dict added to the top-level JSON object, with properties whose values are a JSON list of ID numbers (for anonymous) or names (for non-anonymous) of the relevant annotators
- for "gate" JSON it's the same dict added under the "features" section
- for "csv" the lists of IDs/names are flattened into a string the same way as multi-valued annotation elements
The export process adds entries to the doc_dict, so we should clone it first to ensure such changes are not accidentally persisted to the database if the model object is saved after a call to get_doc_annotation_dict.
Include details of rejected/aborted/timed out annotations in the export
Fixes for various export related issues
@ianroberts ianroberts marked this pull request as draft February 26, 2024 18:05
@ianroberts ianroberts closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants