-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand/hhdb conditions #803
Rebrand/hhdb conditions #803
Conversation
Hey @mexi-cano - is the Step 2 error Ivonne found here the same one you were looking at in the other PR? @ivonne-hernandez can I snag a screenshot of what the page looks like now? |
@sydney-devine Let me know if you're not able to see the screenshot of the error that I attached in the PR. |
Oh sorry my note wasn't clear. Screenshot of what the household conditions etc. addressed in this PR looks like now. Pleeease :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What (if any) features are you implementing?
What (if anything) did you refactor?
OptionCardGroup
to match the comps and made it dynamic so that we could use it for the immediate needs question.current-household-member
.Were there any issues that arose?
Marianna/734/typography-updates
into my branch theIncome Type
dropdown stopped working. As a result I removed theSubHeaderWrapper
that was causing the issue and deleted the file all together since it was just an empty div with asecondary-heading
css class.validateDOMNesting(...)
error that showed up on the landing page (step-2
) indicating that thediv
below it cannot appear as a descendant ofp
:Is there anything that you need from your teammate?
Demo of the refactored
HouseholdDataBlock
:https://github.com/Gary-Community-Ventures/benefits-calculator/assets/86989161/34fb123e-fbdb-4b99-abcd-f6c70e09def2
Demo of the refactored
Step-9
for Immediate Needs:https://github.com/Gary-Community-Ventures/benefits-calculator/assets/86989161/cd4ac42d-e8b5-44c2-b510-897c3406583e