Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand/hhdb conditions #803

Merged
merged 100 commits into from
Dec 14, 2023

Conversation

ivonne-hernandez
Copy link
Collaborator

@ivonne-hernandez ivonne-hernandez commented Dec 8, 2023

What (if any) features are you implementing?

  • Health insurance background/alternating background colors #FBF9FC
  • Income sections should wind up alternating between white background and #FBF9FC
  • Do you have income Yes/No - Selected circle is Mid Blue #41528C
  • "+ ADD ANOTHER INCOME" - update font, color is Mid Blue #41528C

What (if anything) did you refactor?

  • I updated the OptionCardGroup to match the comps and made it dynamic so that we could use it for the immediate needs question.
  • I changed the outline color of the current-household-member.

Were there any issues that arose?

  • After I merged the Marianna/734/typography-updates into my branch the Income Type dropdown stopped working. As a result I removed the SubHeaderWrapper that was causing the issue and deleted the file all together since it was just an empty div with a secondary-heading css class.
  1. @sydney-devine There is a validateDOMNesting(...) error that showed up on the landing page (step-2) indicating that the div below it cannot appear as a descendant of p:
Div cannot appear as a descendant of p
  1. Additionally, in looking at the other changes that were made and are already merged into this branding changes PR, we'll have to run the accessibility audit again to see where we're at in that regard. Some icons became images and vice versa so I'd like to see how those changes impacted accessibility.

Is there anything that you need from your teammate?

  • Please review and let me know if you have any questions, or concerns.

Demo of the refactored HouseholdDataBlock:
https://github.com/Gary-Community-Ventures/benefits-calculator/assets/86989161/34fb123e-fbdb-4b99-abcd-f6c70e09def2

Demo of the refactored Step-9 for Immediate Needs:
https://github.com/Gary-Community-Ventures/benefits-calculator/assets/86989161/cd4ac42d-e8b5-44c2-b510-897c3406583e

@sydney-devine
Copy link
Collaborator

What (if any) features are you implementing?

  • Health insurance background/alternating background colors #FBF9FC
  • Income sections should wind up alternating between white background and #FBF9FC
  • Do you have income Yes/No - Selected circle is Mid Blue #41528C
  • "+ ADD ANOTHER INCOME" - update font, color is Mid Blue #41528C

What (if anything) did you refactor?

  • I updated the OptionCardGroup to match the comps and made it dynamic so that we could use it for the immediate needs question.

Were there any issues that arose?

  • After I merged the Marianna/734/typography-updates into my branch the Income Type dropdown stopped working. As a result I removed the SubHeaderWrapper that was causing the issue and deleted the file all together since it was just an empty div with a secondary-heading css class.
  • @sydney-devine There is a validateDOMNesting(...) error that showed up on the landing page (step-2) indicating that the div below it cannot appear as a descendant of :
Div cannot appear as a descendant of p Is there anything that you need from your teammate?
  • Please review and let me know if you have any questions, or concerns.

Hey @mexi-cano - is the Step 2 error Ivonne found here the same one you were looking at in the other PR?

@ivonne-hernandez can I snag a screenshot of what the page looks like now?

@ivonne-hernandez
Copy link
Collaborator Author

What (if any) features are you implementing?

  • Health insurance background/alternating background colors #FBF9FC
  • Income sections should wind up alternating between white background and #FBF9FC
  • Do you have income Yes/No - Selected circle is Mid Blue #41528C
  • "+ ADD ANOTHER INCOME" - update font, color is Mid Blue #41528C

What (if anything) did you refactor?

  • I updated the OptionCardGroup to match the comps and made it dynamic so that we could use it for the immediate needs question.

Were there any issues that arose?

  • After I merged the Marianna/734/typography-updates into my branch the Income Type dropdown stopped working. As a result I removed the SubHeaderWrapper that was causing the issue and deleted the file all together since it was just an empty div with a secondary-heading css class.
  • @sydney-devine There is a validateDOMNesting(...) error that showed up on the landing page (step-2) indicating that the div below it cannot appear as a descendant of :
Div cannot appear as a descendant of p Is there anything that you need from your teammate?
  • Please review and let me know if you have any questions, or concerns.

Hey @mexi-cano - is the Step 2 error Ivonne found here the same one you were looking at in the other PR?

@ivonne-hernandez can I snag a screenshot of what the page looks like now?

@sydney-devine Let me know if you're not able to see the screenshot of the error that I attached in the PR.

@sydney-devine
Copy link
Collaborator

What (if any) features are you implementing?

  • Health insurance background/alternating background colors #FBF9FC
  • Income sections should wind up alternating between white background and #FBF9FC
  • Do you have income Yes/No - Selected circle is Mid Blue #41528C
  • "+ ADD ANOTHER INCOME" - update font, color is Mid Blue #41528C

What (if anything) did you refactor?

  • I updated the OptionCardGroup to match the comps and made it dynamic so that we could use it for the immediate needs question.

Were there any issues that arose?

  • After I merged the Marianna/734/typography-updates into my branch the Income Type dropdown stopped working. As a result I removed the SubHeaderWrapper that was causing the issue and deleted the file all together since it was just an empty div with a secondary-heading css class.
  • @sydney-devine There is a validateDOMNesting(...) error that showed up on the landing page (step-2) indicating that the div below it cannot appear as a descendant of :
Div cannot appear as a descendant of p Is there anything that you need from your teammate?
  • Please review and let me know if you have any questions, or concerns.

Hey @mexi-cano - is the Step 2 error Ivonne found here the same one you were looking at in the other PR?
@ivonne-hernandez can I snag a screenshot of what the page looks like now?

@sydney-devine Let me know if you're not able to see the screenshot of the error that I attached in the PR.

Oh sorry my note wasn't clear. Screenshot of what the household conditions etc. addressed in this PR looks like now. Pleeease :)

src/Assets/styleController.ts Outdated Show resolved Hide resolved
src/Assets/styleController.ts Outdated Show resolved Hide resolved
src/Assets/styleController.ts Outdated Show resolved Hide resolved
@ivonne-hernandez ivonne-hernandez added the impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review. label Dec 14, 2023
Copy link
Collaborator

@CalebPena CalebPena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalebPena CalebPena merged commit 41c0ba6 into Marianna/734/typography-updates Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants