Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/language select update #777

Merged

Conversation

mexi-cano
Copy link
Collaborator

@mexi-cano mexi-cano commented Dec 4, 2023

What (if any) features are you implementing?

  • Selected language is always shown. If none, 'Choose Language' will show. Select chevron now appear.

What (if anything) did you refactor?

  • Replaced globe icon.
Screenshot 2023-12-04 at 11 03 05 AM Screenshot 2023-12-04 at 11 17 18 AM Screenshot 2023-12-04 at 11 02 53 AM

Copy link
Collaborator

@CalebPena CalebPena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one quick question.

src/Components/Header/Header.js Show resolved Hide resolved
Copy link
Collaborator

@Mdemenko1 Mdemenko1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CalebPena Does @mexi-cano needs to change base branch?

@CalebPena
Copy link
Collaborator

@CalebPena Does @mexi-cano needs to change base branch?

Yes, please change the base branch to the branding changes feature branch.

@bespinosa01 bespinosa01 changed the base branch from main to Marianna/734/typography-updates December 6, 2023 15:48
@mexi-cano mexi-cano linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@sydney-devine sydney-devine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visuals look good on my end.

@CalebPena CalebPena merged commit b5e90b2 into Marianna/734/typography-updates Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the language select at the top to show the selected language
4 participants