Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Citizen Filter With Other Categories #767

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

CalebPena
Copy link
Collaborator

@CalebPena CalebPena commented Nov 28, 2023

What (if any) features are you implementing?

  • Add other citizenship categories.

What (if anything) did you refactor?

  • Update the CitizenshipPopover component to use a citizenship map.
  • Add more spacing between options on mobile.
  • Remove under 19 or pregnant green card option.

Any other comments, questions, or concerns?

  • We need to add the new citizenship options to production and staging.

@CalebPena CalebPena added the impact-medium Moderate possible impact on data, security or user experience. Req 2 reviews. label Nov 28, 2023
@ivonne-hernandez ivonne-hernandez merged commit d5d1848 into main Dec 1, 2023
3 checks passed
Comment on lines +50 to +68
other: <FormattedMessage id="citizenshipFCtrlLabel-other" defaultMessage="Other lawfully present noncitizens" />,
otherWithWorkPermission: (
<FormattedMessage
id="citizenshipFCtrlLabel-other_work_permission"
defaultMessage="with permission to live or work in the U.S. (other rules may apply)"
/>
),
otherHealthCareUnder19: (
<FormattedMessage
id="citizenshipFCtrlLabel-other_health_care_under19"
defaultMessage="for health care benefits - younger than 19"
/>
),
otherHealthCarePregnant: (
<FormattedMessage
id="citizenshipFCtrlLabel-other_health_care_pregnant"
defaultMessage="for health care benefits - pregnant"
/>
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added these labels to the production translations api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-medium Moderate possible impact on data, security or user experience. Req 2 reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants