Refactor/childcare cat header value #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivonne-hernandez
added
the
impact-low
CalebPena
reviewed
Nov 14, 2023
| } | ||
| } | ||
| } | ||
|
|
||
| if (preschoolPrograms.totalEstVal > 8640 && preschoolPrograms.numOfPreSchoolPrograms > 1) { | ||
| categoryValues[preschoolProgramCategoryString] = 8640; | ||
| if (childCareTotalEstVal > 8640) { |
There was a problem hiding this comment.
Did you mean to remove the logic for if there is one preschool program to not cap the value?
CalebPena
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What (if anything) did you refactor?
renderAllCategoryValuesanduseEffectfunctions inResults.tsxby capping the preschool and child care total.Were there any issues that arose?
const isPreschoolOrChildCareProgram = ['upk', 'dpp', 'chs', 'cccap'].includes(program.short_name)hard coded condition that will need to be updated every time we add a new childcare or preschool program.New
Child Care, Youth, and Educationcategory header on desktop:New
Child Care, Youth, and Educationcategory header on mobile: