Feat/add condition #716
Merged
Feat/add condition #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivonne-hernandez
added
the
impact-low
CalebPena
approved these changes
Nov 8, 2023
src/Types/ApiFormData.ts
Outdated
Comment on lines
42
to
51
| student: boolean | null; | ||
| student_full_time?: boolean | null; | ||
| pregnant: boolean | null; | ||
| unemployed?: boolean | null; | ||
| worked_in_last_18_mos?: boolean | null; | ||
| visually_impaired: boolean | null; | ||
| disabled: boolean | null; | ||
| veteran?: boolean | null; | ||
| medicaid?: boolean | null; | ||
| disability_medicaid?: boolean | null; |
There was a problem hiding this comment.
Can we wait until I change the API to make these changes to the API types so that I can remove them all at one time.
There was a problem hiding this comment.
Yes. I've added them back in to this PR. It looks like @sydney-devine created a ticket for us to do this: Gary-Community-Ventures/benefits-api#158 . Can you also update the Swagger Docs when you work on this ticket?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp Ticket: https://app.clickup.com/t/8685ejmf7
What (if any) features are you implementing?
longTermDisabilityto theconditionOptions.What (if anything) did you refactor?
ApiHouseholdMember.Were there any issues that arose? (As of 11/8/23 this Policy Engine issue has been resolved)
Resultspage, I get the following500server error which appears to be caused by aResponse [502]error from Policy Engine on this file.../programs/programs/policyengine/policyengine.py:longTermDisabilityfield is working on theeligibilityendpoint? It is currently working on ourscreensendpoint.Household Memberfields?Updated
conditionsin theHouseholdDataBlockon Desktop:Updated
conditionslisted in theConfirmationcomponent on Desktop:Updated
conditionsin theHouseholdDataBlockon Mobile:Updated
conditionslisted in theConfirmationcomponent on Mobile: