Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add ins hhdb #700

Merged
merged 45 commits into from
Nov 3, 2023
Merged

Feat/add ins hhdb #700

merged 45 commits into from
Nov 3, 2023

Conversation

ivonne-hernandez
Copy link
Collaborator

@ivonne-hernandez ivonne-hernandez commented Nov 1, 2023 •
edited
Loading

ClickUp Ticket: https://app.clickup.com/t/8685hmcqc

What (if any) features are you implementing?

  • I created a HealthInsuranceQ component.
  • I added the HealthInsuranceQ component to the HouseholdDataBlock.

What (if anything) did you refactor?

  • I deleted the healthInsurance question from the stepDirectory flow, as well as initialFormData state.
  • I refactored the validationFunctions
  • I refactored the Confirmation component.
  • I refactored the healthInsuranceOptions to edit current text and add the none, dont_know, family_planning, and emergency_medicaid` options.

Were there any issues that arose?

  • Upon submitting the form, my backend was returning a 500 Internal Server Error so I went in and fixed the following errors on this related BE PR:
Screenshot 2023-11-01 at 2 00 55 PM Screenshot 2023-11-01 at 3 15 55 PM

Is there anything that you need from your teammate?

  • Please pull down the branch and try out the error handling when selecting the None or Don't Know option. Also make sure that it is posting correctly on your local backend.

Desktop view:
Screenshot 2023-11-01 at 2 30 44 PM

Mobile View at 420px and 50% zoom:
Screenshot 2023-11-01 at 2 27 54 PM

Updated Confirmation page:
EN Inline Confirmation

@ivonne-hernandez
Rm healthInsurance from default & referrer step dir
910901c
@ivonne-hernandez
Remove healthInsurance q from qs
43f0720
@ivonne-hernandez
Rm HealthIns type, rm hIns from FormData, add hIns to HHData
67d8b62
@ivonne-hernandez
Rm healthInsurance from initalFormData in Wrapper
6576845
@ivonne-hernandez
Assign the HealthIns interface to healthInsurance
a8bfe65
@ivonne-hernandez
Add healthInsurance to initialHouseholdData state
a09ce42
@ivonne-hernandez
Convert healthInsuranceOptions to tsx
582ca3d
@ivonne-hernandez
Add HealthInsuranceQ component
f159a5e
@ivonne-hernandez
Refactor key value & hhMemberIndex to num type
6172aba
@ivonne-hernandez
Add displayHealthInsuranceQuestion func to HHDB
ea7c503
@ivonne-hernandez
Add cond rend of healthInsQ based on page num
5825676
@ivonne-hernandez
Remove extraneous div from return stmt
2a625d6
@ivonne-hernandez
Rm healthIns from initialFormData & screenBody
00fa51d
@ivonne-hernandez
Add initialHHMHI to initialFormData in fetch & updateScreen
4a9816e
@ivonne-hernandez
Update fetch & updateScreens to use insurance field
e3a8145
@ivonne-hernandez
Refactor personDataIsValid to include healthIns
246a058
@ivonne-hernandez
Add healthInsuranceDataIsValid function
0d12850
@ivonne-hernandez
Add healthIns case to getPersonDataErrorMsg
7e9b14a
@ivonne-hernandez
Move healthInsurance message func out of getPersonDataErrorMsg
a36cebd
@ivonne-hernandez
Add healthInsuranceDataHasError function
1ae2d77
@ivonne-hernandez
Add hIErrorController to HHDB, pass it to HealthInsQ
7da4008
@ivonne-hernandez
Add hInsErrCtrler & display err msg in healthInsQ
85b74e6
@ivonne-hernandez
Delete unused import from Confirmation
f1fceee
@ivonne-hernandez
Delete err from state, useEffect to setError based on personDataErrMsg
4aaa878
@ivonne-hernandez
Move none, add emergency medicaid, famPlanning, DK options
f91c6ec
@ivonne-hernandez
Add dont_know, emerMedicaid & famPlanning to fetchScreen, HHDB
7613b55
@ivonne-hernandez
Change private, medicaid text
f5ec496
@ivonne-hernandez
Add if stmt to X translAriaLabel based on hhMIndex && none key
3930586
@ivonne-hernandez
Change you to I
2e9e637
@ivonne-hernandez
Delete console.log from FetchScreen
0b9031e
@ivonne-hernandez ivonne-hernandez added the impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review. label Nov 1, 2023
CalebPena
CalebPena reviewed Nov 2, 2023
View reviewed changes
.nvmrc Outdated Show resolved Hide resolved
src/Types/FormData.ts
Comment on lines +61 to +63
dont_know: boolean;
emergency_medicaid: boolean;
family_planning: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make these camel case, and then map it when we send/receive it from the API.

src/Assets/validationFunctions.tsx Show resolved Hide resolved
src/Components/HealthInsuranceQ/HealthInsuranceQ.tsx Outdated Show resolved Hide resolved
src/Components/HealthInsuranceQ/HealthInsuranceQ.tsx Outdated Show resolved Hide resolved
src/Components/HealthInsuranceQ/HealthInsuranceQ.tsx Show resolved Hide resolved
src/Components/HouseholdDataBlock/HouseholdDataBlock.js Show resolved Hide resolved
src/Components/HouseholdDataBlock/HouseholdDataBlock.js Outdated Show resolved Hide resolved
@CalebPena CalebPena merged commit ce11d93 into main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebPena CalebPena CalebPena approved these changes

Assignees
No one assigned
Labels
impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivonne-hernandez @CalebPena