Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/updated citizen filters #650

Merged
merged 26 commits into from
Oct 13, 2023
Merged

Conversation

ivonne-hernandez
Copy link
Collaborator

@ivonne-hernandez ivonne-hernandez commented Oct 12, 2023

ClickUp Tickets:

What (if any) features are you implementing?

  • I updated the citizenship filters such that when a user clicks on the green_card option, all of the four green_card subcategories appear checked. When a user deselects the green_card option, the subcategories disappear and are also deselected.
  • The header will only change the number of programs and $ value if a citizenship filter is selected.

Were there any issues that arose?

  • No. The dollar value was changing accurately as expected even with the additional category, eligible and hasBenefit filters from the OtherPopover.

Is there anything that you need from your teammate?

  • Please check out this branch and test the new feature as much as possible and let me know if you have any questions or concerns.

Desktop view:
Screenshot 2023-10-12 at 3 11 25 PM

Mobile view:
Screenshot 2023-10-12 at 3 02 51 PM

Demo:
https://github.com/Gary-Community-Ventures/benefits-calculator/assets/86989161/22d49cf7-35a9-4b79-ba82-c8325f800f9c

Updated Header with different dollar values:
Screenshot 2023-10-12 at 5 42 50 PM

@CalebPena CalebPena added the impact-medium Moderate possible impact on data, security or user experience. Req 2 reviews. label Oct 12, 2023
src/Components/Results/Results.tsx Outdated Show resolved Hide resolved
src/Components/Results/Results.tsx Outdated Show resolved Hide resolved
@ivonne-hernandez ivonne-hernandez merged commit 3bf0cdb into main Oct 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-medium Moderate possible impact on data, security or user experience. Req 2 reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants