Trim input text #1391
Merged
Trim input text #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,27 +61,19 @@ export const ZipcodeStep = () => { | |||
| }); | |||
|
|
|||
| const currentZipcodeValue = watch('zipcode'); | |||
| const shouldShowCountyInput = zipcodeSchema.safeParse(currentZipcodeValue).success; | |||
| const parsedZipCode = zipcodeSchema.safeParse(currentZipcodeValue); | |||
There was a problem hiding this comment.
What do you think about using the original expression? It seems more readable and explicit in terms of why the parsed zip code is being used.
There was a problem hiding this comment.
This fixes a TS error, and allows us to use the parsed zip code in multiple places.
| @@ -164,7 +167,7 @@ export const ZipcodeStep = () => { | |||
| id="questions.zipcode-a-disabledSelectMenuItemText" | |||
| defaultMessage="Select a county" | |||
| />, | |||
| countiesByZipcode[watch('zipcode')], | |||
| countiesByZipcode[parsedZipCode.data], | |||
There was a problem hiding this comment.
What do you think about using the original expression? I understand that there are performance trade offs with using watch in line, but it's more readable and explicit in terms of what the zipcode value is.
There was a problem hiding this comment.
The new way, removes the spaces, so that we don't get a key error.
ivonne-hernandez
requested changes
Dec 5, 2024
ivonne-hernandez
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What (if any) features are you implementing?
I also removed the white space for the other referrer, as I can't think of a reason it would be useful to store the whitespace the user entered.