Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Minesweeper channel accessibility improvements, number tweaks, and cleanup #34

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

rshigg
Copy link
Contributor

@rshigg rshigg commented Jan 21, 2024

Description

After seeing the minesweeper channel on the big stage for the past week (what a feeling!) I am a bit ashamed to admit that I found the visual accessibility lacking. Trying to read dark red text on a black background is a nightmare, especially with an LCD font, and the size of the text, face, and tiles made things worse. This PR aims to remedy those issues.

I also felt like the question marks were popping up a little too often, so I upped the range from 5-10s to 10-20s, if you watched the event and felt differently do let me know.

Changes

  • Increase LCD panel readability by increasing font size, letter-spacing, padding and text color lightness.
  • Increase Face "button" size so it's easier to tell when it changes.
  • Slightly increase tile size.
  • Update question mark range to 10-20s.
  • Move typescript types into a separate file to clean the code up a bit.

Checklist:

Screenshots

Before

DevTools localhost (1)

After

DevTools localhost

chrishanel
chrishanel previously approved these changes Jan 21, 2024
Copy link
Member

@chrishanel chrishanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your design changes are a definite improvement! I did notice during AGDQ 2024 that when this break screen channel was up, the donation total was harder to spot.

Dillon will need to check out the code but design wise I'm happy with the adjustments.

Our broadcast graphics package is still on an older version of
TypeScript that does not support the `satisfies` keyword, so this is
removed for compatibility
@VodBox VodBox merged commit 48852dd into GamesDoneQuick:main Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants