Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): improve backward pagination #4653

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

dolcalmi
Copy link
Collaborator

@dolcalmi dolcalmi commented Nov 8, 2024

  • now it is using new index correctly but the use of skip is a bad practice specially for accounts with more than 500k transactions
  • improve performance removing count query

tests that cover pagination: https://github.com/GaloyMoney/blink/blob/main/core/api/test/integration/services/ledger-service.spec.ts#L59

@github-actions github-actions bot added the core label Nov 8, 2024
@dolcalmi dolcalmi merged commit f62641f into main Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants