Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): update username index #4614

Merged
merged 2 commits into from
Oct 18, 2024
Merged

perf(core): update username index #4614

merged 2 commits into from
Oct 18, 2024

Conversation

dolcalmi
Copy link
Collaborator

@dolcalmi dolcalmi commented Oct 17, 2024 •
edited
Loading

Avg duration is more than 1 second https://ui.honeycomb.io/galoy/datasets/galoy-bbw/result/71kKbg8xRg6?hideCompare

  • Add to username index only records with a valid value
  • Remove regex query (improves performance)
  • Force the use of username index (I tested it directly and for some reason is not using the index without the hint)

@github-actions github-actions bot added the core label Oct 17, 2024
@github-actions github-actions bot added the ci label Oct 17, 2024
@dolcalmi dolcalmi force-pushed the perf-improve-username-index branch 3 times, most recently from 05d7ef5 to 71d8738 Compare October 17, 2024 22:54
@dolcalmi dolcalmi removed the request for review from nicolasburtey October 18, 2024 00:34
@dolcalmi dolcalmi removed the ci label Oct 18, 2024
@dolcalmi dolcalmi force-pushed the perf-improve-username-index branch from 5a5c036 to 663bb83 Compare October 18, 2024 06:32
@dolcalmi dolcalmi enabled auto-merge (squash) October 18, 2024 06:49
openoms
openoms approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@openoms openoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with all tests passing

@dolcalmi dolcalmi merged commit 69c2045 into main Oct 18, 2024
10 checks passed
@galoybot-app galoybot-app bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@openoms openoms openoms approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolcalmi @openoms