fix(core): record correct pubkey for ln payments #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
fix-pubkey-on-payment
branch
3 times, most recently
from
e034099 to
344805c
Compare
vindard
force-pushed
the
fix-pubkey-on-payment
branch
from
344805c to
fdcfeb4
Compare
This reverts commit dc50d89.
vindard
force-pushed
the
fix-pubkey-on-payment
branch
from
fdcfeb4 to
6513270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug where we optimistically assign the default lnd's pubkey to payment entries and we don't change this after it's initially set. This led to the problem where we couldn't update a payment if the pubkey we were looking up for it was false (temporarily mitigated in #4420).
This PR is to be more deliberate with recording/updating the actual pubkey that is used to send a payment as it happens thoughout the send flow.