chore(notifications): boilerplate for html engine #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ impl SmtpClient { | |||
| .from(Mailbox::new(None, self.from_email.parse()?)) | |||
There was a problem hiding this comment.
Note: we can pass in a name here that should be displayed instead of the complete email.
Comment on lines
29
to
31
| handlebars.register_template_file("identification", "./templates/identification.hbs")?; | ||
| handlebars.register_template_file("base", "./templates/layouts/base.hbs")?; | ||
| handlebars.register_template_file("styles", "./templates/partials/styles.hbs")?; |
There was a problem hiding this comment.
better way to handle paths and register name ?
UncleSamtoshi
force-pushed
the
add-html-engine
branch
from
dbe95fa to
3f1098f
Compare
thevaibhav-dixit
force-pushed
the
add-html-engine
branch
from
56dc3a4 to
a1f16a1
Compare
bodymindarts
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.