fix(notifications): handle unrecognized device token in FcmError #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn from(err: google_fcm1::Error) -> Self { | ||
| match err { | ||
| google_fcm1::Error::BadRequest(ref value) => { | ||
| if value["error"]["status"].as_str() == Some("NOT_FOUND") |
There was a problem hiding this comment.
What happens if they keys don’t exist? Can we make this safer
There was a problem hiding this comment.
I mean if we only want to check for the case where device_tokens are unregistered, then this should just suffice.
There was a problem hiding this comment.
I think we can match against the error_codes that field should always be present. as specified here fcm v1 error codes
bodymindarts
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.