chore: re-organize tilt file #3967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7652397 | Triggered | Generic High Entropy Secret | 69a03bc | dev/Tiltfile | View secret |
| 7652397 | Triggered | Generic High Entropy Secret | 69a03bc | dev/Tiltfile | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
vindard
force-pushed
the
re-organize-tilt-file
branch
from
b8f7d3b to
464a390
Compare
vindard
force-pushed
the
re-organize-tilt-file
branch
from
8f51369 to
ae9376a
Compare
vindard
force-pushed
the
re-organize-tilt-file
branch
3 times, most recently
from
adf0962 to
57c6365
Compare
vindard
force-pushed
the
re-organize-tilt-file
branch
from
57c6365 to
4e2c1ff
Compare
|
Taken over by other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparatory step before I do some refactoring to separate out a build step from our Tiltfile
Note for
BUILD_ARGSprepare_build_contextis called insidenpm_test_impland is not its own rule. It doesn't get build if you callbuildon thenpm_test_impltargets so this step still gets built in theteststage. To get around this,prepare_build_contextwould have to be broken out into its own rule and passed around accordingly.