Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix vendir sync action in PRs from external forks #3661

Closed
wants to merge 3 commits into from

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Dec 5, 2023

Description

This brings in the git repo url as well in the case where a PR is opened from a fork outside our own repos. See broken quickstart tests at PR #3657

Github events API spec from docs and sample values from comment

@github-actions github-actions bot added the ci label Dec 5, 2023
@vindard vindard changed the title chore(ci): Fix vendir external merge chore(ci): fix vendir sync action in PRs from external forks Dec 5, 2023
@vindard vindard requested a review from bodymindarts December 5, 2023 20:56
This brings in the git repo url as well in the case where a PR is opened
from a fork outside our own repos.

Github events API sample values from:
https://github.com/orgs/community/discussions/73499#discussioncomment-7483499
Change delimiters to avoid collision with url string that also use the
'/' character.
@vindard
Copy link
Contributor Author

vindard commented Dec 6, 2023

We will merge external forks without running the quickstart job

@vindard vindard closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant