feat: move gt3 library #3641
feat: move gt3 library #3641
Conversation
dolcalmi
commented
Dec 1, 2023
•
dolcalmi
commented
- Move https://github.com/GaloyMoney/gt3-server-node-express-bypass (after merge this can be archived)
- Refactor to only include required sdk files
- Update core to use local reference (this will fix dependabot gh actions issue)
|
(tests are not passing) |
toolchains/workspace-pnpm/macros.bzl
Outdated
| @@ -176,6 +180,10 @@ build_node_modules = rule( | |||
| default = False, | |||
| doc = "Only install production dependencies" | |||
| ), | |||
| "local_packages": attrs.string( | |||
| default = "lib", | |||
There was a problem hiding this comment.
@bodymindarts to accommodate locally vendored npm packages I changed the build_node_modules.py code to also copy those vendored files during the turbo install process.
I know we had originally decided that we want to use the top-level lib folder for common configs across sub-projects. Is this where we also want to store vendored npm packages (like was introduced here), or is there another folder that we'd prefer, maybe third-party?
There was a problem hiding this comment.
if lib it is a folder for common configs then is not a good name, also, tracing-rs does not look like a common config but a library
There was a problem hiding this comment.
lib is a folder for shared libraries....
Some shared libraries may contain common config (that is imported as a library).
There was a problem hiding this comment.
si uses their lib folder for all shared libraries so I think you're right, this is the right approach here
https://github.com/systeminit/si/tree/main/lib
vindard
force-pushed
the
feat-move-gt3-library
branch
from
d4916b7 to
e280a12
Compare
vindard
dismissed
nicolasburtey’s stale review
We hae some changes to make to the level we're bringing in vendored libs at in the the build process
During turbo prune, turbo brings in the necessary local package dirs, and figures out the pruned package.json needed. We would need to also bring along the package dependency js files somehow which turbo doesn't seem to handle internally for local packages. This PR is to explitly copy these local package files across during the build_node_modules step after turbo prune. Future improvements: - figure how to simply do this directly with turbo and local packages
dolcalmi
force-pushed
the
feat-move-gt3-library
branch
from
e280a12 to
b3d209c
Compare
This reverts commit e280a12. We will instead bring these in via 'prepare_build_context'
|
Toolchain specific changes: 6c14818...feat-move-gt3-library |
|
Looks like its still failing: |
